Deprecate import Ember from 'ember'
#20686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Apr 22, 2024
NullVoxPopuli
commented
Apr 22, 2024
NullVoxPopuli
commented
Apr 22, 2024
NullVoxPopuli
force-pushed
the
deprecate-import-ember-from-ember
branch
2 times, most recently
from
17a6f91 to
b5eaa95
Compare
NullVoxPopuli
force-pushed
the
deprecate-import-ember-from-ember
branch
from
7a95c95 to
70d0ca8
Compare
NullVoxPopuli
force-pushed
the
deprecate-import-ember-from-ember
branch
from
703a25b to
3e46fe1
Compare
kategengler
reviewed
May 9, 2024
kategengler
reviewed
May 9, 2024
RFC: emberjs/rfcs#1003 Guide: ember-learn/deprecation-app#1381 Advancement: emberjs/rfcs#1015
NullVoxPopuli
force-pushed
the
deprecate-import-ember-from-ember
branch
from
9cfcb7b to
b00fbb3
Compare
kategengler
approved these changes
May 10, 2024
Member
kategengler
left a comment
kategengler
left a comment
There was a problem hiding this comment.
I'd like @ef4 to take a look too
ef4
approved these changes
May 10, 2024
Contributor
|
High priority places that currently hit the deprecation in a stock app:
Chasing all these down and getting them fixed and released is going to be important to make this practical as an until 6.0 deprecation. |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: emberjs/rfcs#1003
Guide: ember-learn/deprecation-app#1381
Advancement: emberjs/rfcs#1015